From 7f175ed96311b809518411d8d4be495c95b15d19 Mon Sep 17 00:00:00 2001 From: JohnE Date: Sun, 25 Jan 2026 00:33:59 -0800 Subject: [PATCH] MOD: now called VideoAspectRatio --- .../plugin_integration_test.dart | 2 +- example/lib/diagnostic_main.dart | 2 +- example/lib/main.dart | 4 ++-- lib/splash_video_enums.dart | 2 +- lib/video_config.dart | 10 +++++----- lib/widgets/splash_video_player_w.dart | 6 +++--- test/video_config_test.dart | 18 +++++++++--------- 7 files changed, 22 insertions(+), 22 deletions(-) diff --git a/example/integration_test/plugin_integration_test.dart b/example/integration_test/plugin_integration_test.dart index 5795f6d..03d18d6 100644 --- a/example/integration_test/plugin_integration_test.dart +++ b/example/integration_test/plugin_integration_test.dart @@ -344,7 +344,7 @@ void main() { testWidgets('supports different visibility modes', (WidgetTester tester) async { - for (final mode in VisibilityEnum.values) { + for (final mode in VideoAspectRatio.values) { await tester.pumpWidget( MaterialApp( home: SplashVideo( diff --git a/example/lib/diagnostic_main.dart b/example/lib/diagnostic_main.dart index 07b315c..73b181a 100644 --- a/example/lib/diagnostic_main.dart +++ b/example/lib/diagnostic_main.dart @@ -91,7 +91,7 @@ class _DiagnosticPageState extends State { }, videoConfig: VideoConfig( playImmediately: true, - videoVisibilityEnum: VisibilityEnum.useFullScreen, + videoVisibilityEnum: VideoAspectRatio.useFullScreen, onPlayerInitialized: (player) { debugPrint('🎬 Player initialized callback'); setState(() { diff --git a/example/lib/main.dart b/example/lib/main.dart index 1b906f9..5be7cb7 100644 --- a/example/lib/main.dart +++ b/example/lib/main.dart @@ -61,7 +61,7 @@ class InitialSplashExample extends StatelessWidget { backgroundColor: Colors.black, nextScreen: const ExampleSelector(), videoConfig: const VideoConfig( - videoVisibilityEnum: VisibilityEnum.useFullScreen, + videoVisibilityEnum: VideoAspectRatio.useFullScreen, ), onVideoError: (error) { debugPrint('Initial Splash Video Error: $error'); @@ -294,7 +294,7 @@ class AutoNavigateExample extends StatelessWidget { nextScreen: const HomeScreen(title: 'Auto-Navigate Example'), backgroundColor: Colors.black, videoConfig: const VideoConfig( - videoVisibilityEnum: VisibilityEnum.useFullScreen, + videoVisibilityEnum: VideoAspectRatio.useFullScreen, ), onVideoError: (error) { debugPrint('Video Error in AutoNavigateExample: $error'); diff --git a/lib/splash_video_enums.dart b/lib/splash_video_enums.dart index 2838b8b..8f8cf61 100644 --- a/lib/splash_video_enums.dart +++ b/lib/splash_video_enums.dart @@ -21,7 +21,7 @@ */ /// Controls how the video is displayed on screen -enum VisibilityEnum { +enum VideoAspectRatio { /// Display video in full screen, filling the entire available space useFullScreen, diff --git a/lib/video_config.dart b/lib/video_config.dart index 7df02e2..7be3421 100644 --- a/lib/video_config.dart +++ b/lib/video_config.dart @@ -28,7 +28,7 @@ class VideoConfig { /// Creates a VideoConfig with the specified options const VideoConfig({ this.playImmediately = true, - this.videoVisibilityEnum = VisibilityEnum.useFullScreen, + this.videoVisibilityEnum = VideoAspectRatio.useFullScreen, this.useSafeArea = false, this.volume = 80.0, this.enableAudio = true, @@ -56,10 +56,10 @@ class VideoConfig { /// How the video should be displayed on screen /// - /// - [VisibilityEnum.useFullScreen]: Fill the entire screen - /// - [VisibilityEnum.useAspectRatio]: Maintain video's aspect ratio - /// - [VisibilityEnum.none]: No special sizing - final VisibilityEnum videoVisibilityEnum; + /// - [VideoAspectRatio.useFullScreen]: Fill the entire screen + /// - [VideoAspectRatio.useAspectRatio]: Maintain video's aspect ratio + /// - [VideoAspectRatio.none]: No special sizing + final VideoAspectRatio videoVisibilityEnum; /// Initial volume level (0.0 to 100.0) /// diff --git a/lib/widgets/splash_video_player_w.dart b/lib/widgets/splash_video_player_w.dart index 4f8c710..d55d0fc 100644 --- a/lib/widgets/splash_video_player_w.dart +++ b/lib/widgets/splash_video_player_w.dart @@ -261,7 +261,7 @@ class _SplashVideoPlayerState extends State { Widget _buildMediaWidget() { switch (videoConfig.videoVisibilityEnum) { - case VisibilityEnum.useFullScreen: + case VideoAspectRatio.useFullScreen: return SizedBox.fromSize( size: MediaQuery.sizeOf(context), child: Video( @@ -269,7 +269,7 @@ class _SplashVideoPlayerState extends State { controls: NoVideoControls, ), ); - case VisibilityEnum.useAspectRatio: + case VideoAspectRatio.useAspectRatio: return AspectRatio( aspectRatio: player.state.width != null && player.state.height != null ? player.state.width! / player.state.height! @@ -279,7 +279,7 @@ class _SplashVideoPlayerState extends State { controls: NoVideoControls, ), ); - case VisibilityEnum.none: + case VideoAspectRatio.none: return Video( controller: controller, controls: NoVideoControls, diff --git a/test/video_config_test.dart b/test/video_config_test.dart index b260473..7ad3b0c 100644 --- a/test/video_config_test.dart +++ b/test/video_config_test.dart @@ -30,7 +30,7 @@ void main() { const config = VideoConfig(); expect(config.playImmediately, isTrue); - expect(config.videoVisibilityEnum, equals(VisibilityEnum.useFullScreen)); + expect(config.videoVisibilityEnum, equals(VideoAspectRatio.useFullScreen)); expect(config.useSafeArea, isFalse); expect(config.volume, equals(100.0)); expect(config.onPlayerInitialized, isNull); @@ -39,14 +39,14 @@ void main() { test('creates with custom values', () { final config = VideoConfig( playImmediately: false, - videoVisibilityEnum: VisibilityEnum.useAspectRatio, + videoVisibilityEnum: VideoAspectRatio.useAspectRatio, useSafeArea: true, volume: 50.0, onPlayerInitialized: (player) {}, ); expect(config.playImmediately, isFalse); - expect(config.videoVisibilityEnum, equals(VisibilityEnum.useAspectRatio)); + expect(config.videoVisibilityEnum, equals(VideoAspectRatio.useAspectRatio)); expect(config.useSafeArea, isTrue); expect(config.volume, equals(50.0)); expect(config.onPlayerInitialized, isNotNull); @@ -85,15 +85,15 @@ void main() { group('VisibilityEnum', () { test('has all expected values', () { - expect(VisibilityEnum.values.length, equals(3)); - expect(VisibilityEnum.values, contains(VisibilityEnum.useFullScreen)); - expect(VisibilityEnum.values, contains(VisibilityEnum.useAspectRatio)); - expect(VisibilityEnum.values, contains(VisibilityEnum.none)); + expect(VideoAspectRatio.values.length, equals(3)); + expect(VideoAspectRatio.values, contains(VideoAspectRatio.useFullScreen)); + expect(VideoAspectRatio.values, contains(VideoAspectRatio.useAspectRatio)); + expect(VideoAspectRatio.values, contains(VideoAspectRatio.none)); }); test('values are unique', () { - final values = VisibilityEnum.values.toSet(); - expect(values.length, equals(VisibilityEnum.values.length)); + final values = VideoAspectRatio.values.toSet(); + expect(values.length, equals(VideoAspectRatio.values.length)); }); }); }