j3g
/
lum_platform_image_converter
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #23 from koji-1009/refactor/using 

refactor: use JNI Arena for automatic resource management
This commit is contained in:
Koji Wakamiya 2025-12-29 07:20:05 +09:00 committed by GitHub
parent 95f864213e a0b8a68cdb
commit d7ffa28265
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 12 additions and 30 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
lib/src/android/native.dart
View File

@ -40,20 +40,13 @@ final class ImageConverterAndroid implements ImageConverterPlatform {
int quality = 100,
ResizeMode resizeMode = const OriginalResizeMode(),
}) async {
JByteArray? inputJBytes;
Bitmap? originalBitmap;
Bitmap? scaledBitmap;
Bitmap? bitmapToCompress;
Bitmap$CompressFormat? compressFormat;
ByteArrayOutputStream? outputStream;
JByteArray? outputJBytes;
try {
inputJBytes = JByteArray.from(inputData);
originalBitmap = BitmapFactory.decodeByteArray(
return using((arena) {
final inputJBytes = JByteArray.from(inputData)..releasedBy(arena);
final originalBitmap = BitmapFactory.decodeByteArray(
inputJBytes,
0,
inputData.length,
);
)?..releasedBy(arena);
if (originalBitmap == null) {
throw const ImageDecodingException('Invalid image data.');
}
@ -65,26 +58,24 @@ final class ImageConverterAndroid implements ImageConverterPlatform {
originalHeight,
);
final Bitmap? bitmapToCompress;
if (newWidth == originalWidth && newHeight == originalHeight) {
bitmapToCompress = originalBitmap;
} else {
scaledBitmap = Bitmap.createScaledBitmap(
bitmapToCompress = Bitmap.createScaledBitmap(
originalBitmap,
newWidth,
newHeight,
true, // filter
);
bitmapToCompress = scaledBitmap;
)?..releasedBy(arena);
}
if (bitmapToCompress == null) {
// This should not happen if originalBitmap is valid
throw const ImageConversionException(
'Bitmap could not be prepared for compression.',
);
}
compressFormat = switch (format) {
final compressFormat = switch (format) {
OutputFormat.jpeg => Bitmap$CompressFormat.JPEG,
OutputFormat.png => Bitmap$CompressFormat.PNG,
// TODO: WebP is deprecated since Android 10, consider using WebP_LOSSY or WebP_LOSSLESS
@ -92,9 +83,9 @@ final class ImageConverterAndroid implements ImageConverterPlatform {
OutputFormat.heic => throw UnsupportedError(
'HEIC output format is not supported on Android.',
),
};
}..releasedBy(arena);
outputStream = ByteArrayOutputStream();
final outputStream = ByteArrayOutputStream()..releasedBy(arena);
final success = bitmapToCompress.compress(
compressFormat,
quality,
@ -104,7 +95,7 @@ final class ImageConverterAndroid implements ImageConverterPlatform {
throw ImageEncodingException(format, 'Failed to compress bitmap.');
}
outputJBytes = outputStream.toByteArray();
final outputJBytes = outputStream.toByteArray()?..releasedBy(arena);
if (outputJBytes == null) {
throw ImageEncodingException(
format,
@ -113,15 +104,6 @@ final class ImageConverterAndroid implements ImageConverterPlatform {
}
return Uint8List.fromList(outputJBytes.toList());
} finally {
inputJBytes?.release();
originalBitmap?.recycle();
originalBitmap?.release();
scaledBitmap?.recycle();
scaledBitmap?.release();
compressFormat?.release();
outputStream?.release();
outputJBytes?.release();
}
});
}
}